Skip to content

feat(node_api): Add missing functions #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(node_api): Add missing functions #7

wants to merge 6 commits into from

Conversation

@abhisekp
Copy link

@abhisekp abhisekp commented Feb 15, 2025 •
edited
Loading

Need proper testing

These are created using Cursor IDE using gpt4o using the following link as reference https://nodejs.org/docs/latest/api/n-api.html

@abhisekp abhisekp marked this pull request as draft February 15, 2025 16:32
@abhisekp
Copy link
Author

abhisekp commented Feb 15, 2025 •
edited
Loading

@akshayganeshen Please review. Wherever required you can make the changes or ask me to make them.
And then we can finalize for this to merge.

I'm very new to these things. I learnt about this yesterday and released a package using this library to demonstrate various use cases https://www.npmjs.com/package/@abhisekp/go-native

@abhisekp abhisekp force-pushed the feat-missing-functions branch from bb56e7b to 18b306e Compare February 15, 2025 21:51
@abhisekp
Copy link
Author

abhisekp commented Feb 15, 2025

Meanwhile, I have the new code ready for install https://github.com/abhisekp/napi-go

go get github.com/abhisekp/napi-go

@abhisekp abhisekp force-pushed the feat-missing-functions branch from 0587a26 to b1dad34 Compare February 16, 2025 06:10
@abhisekp
feat(js_native_api): Add missing functions
7fe5204 
feat(node_api): Add missing functions
@abhisekp abhisekp force-pushed the feat-missing-functions branch from b1dad34 to 7fe5204 Compare February 16, 2025 07:15
@abhisekp
feat(node_api): Remove incorrect function
02f0127
@abhisekp
fix(value_type): Add value types
1851696
@abhisekp
fix(node_api): Add stdlib header
c546935 
(cherry picked from commit 893b005)
@abhisekp
chore(git): Add gitignore
fa8b178 
(cherry picked from commit bd840a9)
@abhisekp
fix(node_api): Fix functions
1efcf1a 
- Remove unfixable functions (Add to CONTRIBUTING.md file as TODO)
- Add key types

(cherry picked from commit a4aff16)
@akshayganeshen
Copy link
Owner

akshayganeshen commented Feb 25, 2025

Hey @abhisekp, this is really great! Thank you so much for putting this together!

I'll need a few weeks to test it, the plan is to just put together enough docs/examples/ to cover everything new. I'll also want to tweak the CONTRIBUTING.md guidelines a bit since I never really fleshed that out, but that's a pretty minor piece.

Will let you know if there's any changes I want to request, but for now this seems pretty solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhisekp @akshayganeshen